Wikipedia:Bots/Requests for approval/APersonBot 3

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was  Approved.

Operator: APerson (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 03:30, Wednesday, August 12, 2015 (UTC)

Automatic, Supervised, or Manual: Supervised

Programming language(s): Python

Source code available: https://github.com/APerson241/APersonBot/blob/master/teahouse-invite/teahouse-invite.py

Function overview: Fixes an error with the duplication of {{Wikipedia:Teahouse/AfC Invitation}} on user talk pages.

Links to relevant discussions (where appropriate): WT:AFCH#Teahouse invite (permalink)

Edit period(s): One time run

Estimated number of pages affected: On the order of 10,000

Exclusion compliant (Yes/No): No

Already has a bot flag (Yes/No): Yes

Function details: As seen in the discussion, I accidentally introduced an error in the code of the invitation template that makes it possible for multiple notices to end up on the same user talk page. This bot task will remove duplicate occurrences of the template while adding the correct category. It isn't exclusion compliant because we're fixing an error in the template code itself anyway. (Although I can make it exclusion compliant with no trouble.)

Discussion

• Approved for trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. -- Magioladitis (talk) 17:56, 14 August 2015 (UTC)[reply]

  @APerson: Status of this? — Earwig ^talk 05:27, 11 September 2015 (UTC)[reply]

  The Earwig, the main issue I'm having is finding pages to edit. At the moment, I'm snarfing through all user talk pages, which I know is quite inefficient. Oddly enough, using search results doesn't work for me. I'm continuing to improve how the bot finds pages, as that's the main thing holding up the trial. APerson (talk!) 12:01, 11 September 2015 (UTC)[reply]

  @APerson: I don't know if you've got anything done recently, but might it help to search backlinks to File:WP teahouse logo 2.png? →Σσς. (Sigma) 17:53, 24 October 2015 (UTC)[reply]

  Σ, what a great idea! Testing that right now. APerson (talk!) 21:31, 24 October 2015 (UTC)[reply]

• Trial complete. You can see the edits the bot made for this trial with this edit summary search. APerson (talk!) 19:27, 25 October 2015 (UTC)[reply]

  @APerson: So:

  • Will you mark these as bot edits after approval? I want to avoid people getting notifications, and if I recall correctly, that only happens when edits are marked as minor+bot.
  • Could you add the category right after the invitation rather than at the end of the page? Keeps them together and prevents the cat from being added to an unrelated section. This is a good example.
  • I would normally suggest stripping the extra whitespace that you're adding, since it's a bit unsightly, but that looks like a more underlying problem with the script or template substitution. Could you take a look?
  • As a final point, I suggest turning on exclusion compliance, since there are a lot of pages involved here.

  — Earwig ^talk 02:52, 26 October 2015 (UTC)[reply]

  I automatically get edits marked as minor bot edits from Pywikibot, as well as exclusion compliance. I will set it to add the category after the invitation, and to remove the extra whitespace. Earwig, do you want me to run it for a few edits with these changes, or is the bot ready to be approved? APerson (talk!) 14:48, 26 October 2015 (UTC)[reply]

   Approved. Seems fine to me, just do a quick few-edit test before you unleash the bot to verify. — Earwig ^talk 15:35, 26 October 2015 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.